-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added File Upload Component #512
Conversation
Swappea
commented
Nov 1, 2024
•
edited
Loading
edited
- Added new file upload components which is accessible in nature.
- Components are present to show list of uploaded files, show an image preview if needed, show file size, and ability to remove those files.
✅ Deploy Preview for kobalte ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@jer3m01 - I have fixed the formatting issues, could you please approve the workflow so I can check if formatting is as expected? Also could you please review the PR?
|
Yeah the docs aren't the nicest to write, this is being worked on 👀. |
@jer3m01 - any idea on how to fix the formatting issue I am getting? Within VSCode, if I format using prettier I don't see any issues. Is there any command that I am probably missing? |
You can run |
Wow for some reason after running this command, over 500 files were changed as per git but there were no visible changes. I have pushed the 2 files which were showing issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the interest and the work!
I've noted a few issues but it mostly looks good.
Could another example be added to the docs for HTML form submissions, like there is for TextField
but instead maybe only write the submitted file names in the alert()
.
Thanks again for the PR!
packages/core/src/file-upload/file-upload-item-delete-trigger.tsx
Outdated
Show resolved
Hide resolved
@jer3m01 - updated please check.. |
Thanks for the changes! A few classes haven't been removed yet, I unresolved the cases. |
Sorry, missed removing those, not sure how. All the classes have now been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the PR and changes!
Will merge soon.