Add support for Software computed CRC32 #260
koculuAnnotations
11 warnings
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build:
src/ZoneTree/Core/ZoneTreeMaintainer.cs#L41
Member 'ThresholdForMergeOperationStart' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
|
|
build:
src/ZoneTree/Segments/Disk/CircularCache.cs#L25
Member 'statsCacheHit' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
|
|
build:
src/ZoneTree/Segments/Disk/CircularCache.cs#L27
Member 'statsCacheMiss' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
|
|
build:
src/ZoneTree/Core/TypeExtensions.cs#L23
Use 'StringBuilder.Append(char)' instead of 'StringBuilder.Append(string)' when the input is a constant unit string (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834)
|
|
build:
src/ZoneTree/Core/TypeExtensions.cs#L34
Use 'StringBuilder.Append(char)' instead of 'StringBuilder.Append(string)' when the input is a constant unit string (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1834)
|
|
build:
src/ZoneTree/Core/TypeExtensions.cs#L13
'string.IndexOf(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Tenray.ZoneTree.Core.TypeExtensions.SimplifiedFullName(System.Type)' with a call to 'string.IndexOf(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
build:
src/ZoneTree/Core/TypeExtensions.cs#L16
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
|
|
build:
src/ZoneTree/Serializers/UnicodeStringSerializer.cs#L14
Member 'Deserialize' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
build:
src/ZoneTree/Segments/Disk/CircularCache.cs#L29
Use properties where appropriate (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1024)
|
|
build:
src/ZoneTree/Segments/RandomAccess/FileRandomAccessDevice.cs#L62
In member Memory<byte> FileRandomAccessDevice.GetBytes(long offset, int length, SingleBlockPin pin), change parameter name pin to blockPin in order to match the identifier as it has been declared in Memory<byte> IRandomAccessDevice.GetBytes(long offset, int length, SingleBlockPin blockPin = null) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|