✨ Collection Activity Tab #5345
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
exezbcz
changed the title
|
looks neat!
|
…llection-activity-tab
| const mintInteraction = events[0] | ||
| const mintTimeStamp = new Date(mintInteraction.timestamp).getTime() | ||
|
|
||
| owners[nft.currentOwner] = |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
@vikiival seriously?
| .flat() | ||
| } | ||
|
|
||
| const getOwners = (nfts) => { |
There was a problem hiding this comment.
Function getOwners has 38 lines of code (exceeds 25 allowed). Consider refactoring.
There was a problem hiding this comment.
@vikiival I don't think that there will be anything gained by trying to reduce it farther, same goes for getFlippers
There was a problem hiding this comment.
update: managed to reduce getFlippers to 38
|
build fails:
|
should be fixed with this #5398 |
| .fixed-width { | ||
| width: 66px; | ||
| } | ||
| .fixed-height { | ||
| height: 22px; | ||
| } | ||
| .height-50px { | ||
| height: 50px; | ||
| } |
There was a problem hiding this comment.
do we need to set fixed height & width?
There was a problem hiding this comment.
long discussion about this with @exezbcz in discord...
yes
There was a problem hiding this comment.
altough fixed height can probably be dropped
There was a problem hiding this comment.
they look pretty random numbers, wdyt about changing this to inner spacing
There was a problem hiding this comment.
dropping fixed height causes height diff between desktop and tablet view
i guess min-height could solve it, but what would be the point of that then?
components/collection/activity/ownerInsightsTabs/NFTSDetailsDropdown/Flipper.vue
Outdated
Show resolved
Hide resolved
components/collection/activity/ownerInsightsTabs/NFTSDetailsDropdown/Flipper.vue
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,122 @@ | |||
| <template> | |||
| <b-collapse | |||
There was a problem hiding this comment.
moving it to the follow up issue with your permission
| } | ||
|
|
||
|
|
||
| //colors |
There was a problem hiding this comment.
have you seen in styles/abstracts/variables.scss it should do the work you looking for
There was a problem hiding this comment.
honestly i could not figure it out
…llection-activity-tab
…ft-gallery into collection-activity-tab
|
Code Climate has analyzed commit 9f4865d and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
|
|
Continue @daiagi here |
Isn't it p4? |
|
@daiagi I think this one is the issue we should focus on |
Thank you for your contribution to the KodaDot NFT gallery.
@yangwao Deliverd on time?
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸
tested on these collections: