Activity-chart-outliers #6138

daiagi · 2023-05-31T07:44:48Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Closes Show outliers on chart in activity #6109
Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

$

My DOT address: Payout

Copilot Summary

`🤖 Generated by Copilot at 87c592d`

Improved the collection activity price chart by filtering out outlier data points using a new removeOutliers function. Added median and medianAbsoluteDeviation functions to @/utils/math for general math utilities.

`🤖 Generated by Copilot at 87c592d`

We'll filter out the outliers from the data points
With median and medianAbsoluteDeviation
We'll make the price chart more reliable and fair
Heave away, me hearties, heave away

Screenshots

Before

After

kodabot · 2023-05-31T07:44:52Z

SUCCESS @daiagi PR for issue #6109 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2023-05-31T07:44:52Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`6ac499b`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6499698eb7925500081435e2
😎 Deploy Preview	https://deploy-preview-6138--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

reviewpad · 2023-05-31T07:45:30Z

AI-Generated Summary: This pull request consists of two patches:

The first patch adds two new math utility functions in utils/math.ts file:
- median() function calculates the median of an array of numbers.
- mediaAbsoluteDeviation() function calculates the median absolute deviation (MAD) of an array of numbers.
The second patch makes changes to ActivityChart.vue and activity/utils.ts files:
- It imports the removeOutliers function and uses this function to filter outlier data points from the list events.
- In activity/utils.ts, a new removeOutliers() function is added. This function filters out data points with a deviation above the specified threshold from the median.

roiLeo

Tested on https://deploy-preview-6138--koda-canary.netlify.app/stmn/collection/2022/activity

Doesn't load for me compared to beta

daiagi · 2023-06-01T10:59:30Z

Tested on https://deploy-preview-6138--koda-canary.netlify.app/stmn/collection/2022/activity

Doesn't load for me compared to beta

hi @roiLeo
I've created this PR:

Test/activity-chart-outliers #6146
to illustrate a point, in that PR there are no code diff compare to main yet that collection doesn't load
https://deploy-preview-6146--koda-canary.netlify.app/stmn/collection/2022/activity

this collection is very big and the issue goes back to these:

roiLeo

hi @roiLeo I've created this PR:

* [Test/activity-chart-outliers #6146](https://github.com/kodadot/nft-gallery/pull/6146)
  to illustrate a point, in that PR there are no code diff compare to main yet that collection doesn't load
  https://deploy-preview-6146--koda-canary.netlify.app/stmn/collection/2022/activity

Alright noted! personally I would have hidden this feature (Activity Tab) for the time being until fixed #5540 (comment)

prury · 2023-06-13T19:12:08Z

About the outliers, they are still present when i open this deployed version:
https://deploy-preview-6138--koda-canary.netlify.app/ksm/gallery/11778219-2644199cf3652aaa78-KQ01-008_PIZZA-00000008

daiagi · 2023-06-14T09:02:42Z

About the outliers, they are still present when i open this deployed version: https://deploy-preview-6138--koda-canary.netlify.app

the issue was about collection activity chart

Show outliers on chart in activity #6109 (comment)

the chart you've mentioned is a single NFT chart and was not touched in this PR

as to the specific example you've presented, not sure why you are saying there are outliers, the graph looks well behaved and easy to read to me

prury · 2023-06-14T11:17:49Z

About the outliers, they are still present when i open this deployed version: https://deploy-preview-6138--koda-canary.netlify.app

the issue was about collection activity chart
* [Show outliers on chart in activity #6109 (comment)](https://github.com/kodadot/nft-gallery/issues/6109#issue-1727133764)
the chart you've mentioned is a single NFT chart and was not touched in this PR

as to the specific example you've presented, not sure why you are saying there are outliers, the graph looks well behaved and easy to read to me

@daiagi I apologize, the whole time i was reading outlines instead of outliners and i did not knew this collection activity page existed, will verify this PR properly today, only did a quick check yesterday and assumed it wasn't working.

prury · 2023-06-14T13:51:41Z

Collection: https://deploy-preview-6138--koda-canary.netlify.app/ksm/collection/dac5c7f54029d0e73c-HXAI8/activity

before:

after:

Collection: https://deploy-preview-6138--koda-canary.netlify.app/ksm/collection/a0c4801b6dbf04c674-P1Z70/activity

before:

after:

Collection: https://deploy-preview-6138--koda-canary.netlify.app/ksm/collection/36bad3dc147db9792b-ARCHIVERSE_BANNERS_ITEMS/activity

before:

after:

Collection: https://deploy-preview-6138--koda-canary.netlify.app/ksm/collection/8453d0ccb4cb7e9e59-A51/activity

before:

after:

so, most charts are looking better than before indeed, not sure if its the best final solution tho, what do you think @yangwao ?

daiagi · 2023-06-17T07:06:54Z

@prury

let's let it roll
there is no "best final solution"
in any case we will need to use 1 method to clean data from charts that may look quite different from each other
it will work better for some and worst for other

it looks better now and the data is easier to read then it was before, so let's continue
we can always tweak it as needed in the future

daiagi · 2023-06-23T06:57:08Z

@Jarsen136 review please?

codeclimate · 2023-06-26T10:34:23Z

Code Climate has analyzed commit 6ac499b and detected 0 issues on this pull request.

View more on Code Climate.

vikiival · 2023-06-26T11:22:06Z

pay 35 usd

yangwao · 2023-06-26T11:22:17Z

😍 Perfect, I’ve sent the payout
💵 $35 @ 5.2 USD/DOT ~ 6.731 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x3cb6a99d643fcdc4d303f84c76707035e757cfcaaa7720e3bf1437857665c141

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

daiagi added 2 commits May 31, 2023 14:42

math util functions

2ee8532

🔥 remove list events outliers from activty chart

87c592d

daiagi requested a review from a team as a code owner May 31, 2023 07:44

daiagi requested review from roiLeo and Jarsen136 and removed request for a team May 31, 2023 07:44

reviewpad bot added small Pull request is small waiting-for-review labels May 31, 2023

roiLeo reviewed Jun 1, 2023

View reviewed changes

roiLeo approved these changes Jun 1, 2023

View reviewed changes

exezbcz mentioned this pull request Jun 1, 2023

Advanced option for chart #6154

Closed

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 13, 2023

prury removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 14, 2023

exezbcz mentioned this pull request Jun 14, 2023

Chart events merge #6221

Open

Merge branch 'main' into activity-chart-outliers

7cffd09

prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 17, 2023

daiagi requested a review from preschian June 23, 2023 06:56

Merge branch 'main' into activity-chart-outliers

3bdaa06

preschian approved these changes Jun 23, 2023

View reviewed changes

Jarsen136 approved these changes Jun 23, 2023

View reviewed changes

Merge branch 'main' into activity-chart-outliers

6ac499b

vikiival merged commit cbe6b72 into main Jun 26, 2023

vikiival deleted the activity-chart-outliers branch June 26, 2023 11:22

yangwao added the paid pull-request has been paid label Jun 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activity-chart-outliers #6138

Activity-chart-outliers #6138

daiagi commented May 31, 2023 •

edited

Loading

kodabot commented May 31, 2023

netlify bot commented May 31, 2023 •

edited

Loading

reviewpad bot commented May 31, 2023

roiLeo left a comment

daiagi commented Jun 1, 2023 •

edited

Loading

roiLeo left a comment

prury commented Jun 13, 2023 •

edited

Loading

daiagi commented Jun 14, 2023

prury commented Jun 14, 2023

prury commented Jun 14, 2023

daiagi commented Jun 17, 2023

daiagi commented Jun 23, 2023

codeclimate bot commented Jun 26, 2023

vikiival commented Jun 26, 2023

yangwao commented Jun 26, 2023

Activity-chart-outliers #6138

Activity-chart-outliers #6138

Conversation

daiagi commented May 31, 2023 • edited Loading

PR Type

Context

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 87c592d

🤖 Generated by Copilot at 87c592d

Screenshots

Before

After

kodabot commented May 31, 2023

netlify bot commented May 31, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented May 31, 2023

roiLeo left a comment

Choose a reason for hiding this comment

daiagi commented Jun 1, 2023 • edited Loading

roiLeo left a comment

Choose a reason for hiding this comment

prury commented Jun 13, 2023 • edited Loading

daiagi commented Jun 14, 2023

prury commented Jun 14, 2023

prury commented Jun 14, 2023

daiagi commented Jun 17, 2023

daiagi commented Jun 23, 2023

codeclimate bot commented Jun 26, 2023

vikiival commented Jun 26, 2023

yangwao commented Jun 26, 2023

daiagi commented May 31, 2023 •

edited

Loading

`🤖 Generated by Copilot at 87c592d`

`🤖 Generated by Copilot at 87c592d`

netlify bot commented May 31, 2023 •

edited

Loading

daiagi commented Jun 1, 2023 •

edited

Loading

prury commented Jun 13, 2023 •

edited

Loading