Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdalgos (4/10): team-level API, and rst update for release 4.2 #390

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

stdalgos (4/10): team-level API, and rst update for release 4.2 #390

wants to merge 7 commits into from

Conversation

mperrinel
Copy link

@mperrinel mperrinel commented May 29, 2023 •
edited by fnrizzi
Loading

Add team-level API to and convert to rst the following algorithms:

Kokkos_Fill.hpp
Kokkos_FillN.hpp
Kokkos_Replace.hpp
Kokkos_ReplaceIf.hpp
Kokkos_ReplaceCopyIf.hpp
Kokkos_ReplaceCopy.hpp

To see rendered pages, open individual html with Firefox (MUST be firefox or it won't display correctly) Archive.zip

@mperrinel mperrinel mentioned this pull request May 29, 2023
Open
@fnrizzi fnrizzi changed the title std_algos: part 5/10 std_algos: part 4/10 May 30, 2023
@fnrizzi fnrizzi mentioned this pull request May 30, 2023
Closed
@fnrizzi fnrizzi changed the title std_algos: part 4/10 std_algos: part 4/10 (DO NOT MERGE UNTIL CODE PR MERGED) Jun 13, 2023
@fnrizzi fnrizzi mentioned this pull request Aug 10, 2023
Merged
@fnrizzi fnrizzi marked this pull request as ready for review December 1, 2023 16:55
@fnrizzi fnrizzi assigned fnrizzi and unassigned fnrizzi Dec 1, 2023
@fnrizzi fnrizzi changed the title std_algos: part 4/10 (DO NOT MERGE UNTIL CODE PR MERGED) stdalgos: part 4/10 (DO NOT MERGE UNTIL CODE PR MERGED) Dec 9, 2023
@fnrizzi fnrizzi changed the title stdalgos: part 4/10 (DO NOT MERGE UNTIL CODE PR MERGED) stdalgos (4/N): team-level API, and rst update for release 4.2 Dec 9, 2023
@fnrizzi fnrizzi changed the title stdalgos (4/N): team-level API, and rst update for release 4.2 stdalgos (4/10): team-level API, and rst update for release 4.2 Dec 10, 2023
ajpowelsnl
ajpowelsnl requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@ajpowelsnl ajpowelsnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnrizzi, @crtrott -- and another with the same changes

docs/source/API/algorithms/std-algorithms/all/StdFill.rst
KE::fill(Kokkos::DefaultExecutionSpace(), a, 22.);

// explicitly set execution space (assuming active)
KE::fill(Kokkos::OpenMP(), KE::begin(a), KE::end(a), 14.);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KE::fill(Kokkos::OpenMP(), KE::begin(a), KE::end(a), 14.);
// // To run explicitly on the Host (assuming a and b are accessible on Host)
KE::fill(Kokkos::DefaultHostExecutionSpace(), KE::begin(a), KE::end(a), 14.);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the explicit space here was done to show, that it is possible to pass any enabled execution space.

docs/source/API/algorithms/std-algorithms/all/StdFill_n.rst Show resolved Hide resolved
docs/source/API/algorithms/std-algorithms/all/StdReplace.rst Show resolved Hide resolved
docs/source/API/algorithms/std-algorithms/all/StdReplaceIf.rst Show resolved Hide resolved
@ajpowelsnl
Copy link
Contributor

@mperrinel - are you still working on this PR?

@fnrizzi
Copy link
Collaborator

fnrizzi commented Jul 1, 2024

@mperrinel - are you still working on this PR?

no he is not in a while

@ajpowelsnl
Copy link
Contributor

@mperrinel - are you still working on this PR?

no he is not in a while

Thanks @fnrizzi! @JBludau , might you be able to take over this PR, and bring it in for a smooth landing?

@JBludau
Copy link
Contributor

JBludau commented Jul 3, 2024

@mperrinel - are you still working on this PR?

no he is not in a while

Thanks @fnrizzi! @JBludau , might you be able to take over this PR, and bring it in for a smooth landing?

I can take a look

@ajpowelsnl
Copy link
Contributor

@crtrott - all requested changes have been made

@JBludau
Copy link
Contributor

JBludau commented Sep 5, 2024

Ok, as I was asked to finish this one:
I reworded some description and did a check of the signatures. It is in a good shape.
@fnrizzi could you confirm it is the correct description of the algos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBludau JBludau JBludau left review comments

@ajpowelsnl ajpowelsnl ajpowelsnl requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mperrinel @ajpowelsnl @fnrizzi @JBludau