-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdalgos (10/10): team-level API, and rst update for release 4.2 #440
Draft
antoinemeyer5
wants to merge
13
commits into
kokkos:main
Choose a base branch
from
antoinemeyer5:std_teamlevel_p10of10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2023
fnrizzi
changed the title
std_algos: part 10/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED)
stdalgos: part 10/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED)
Dec 9, 2023
fnrizzi
changed the title
stdalgos: part 10/10: add team-level API and convert to rst (DO NOT MERGE UNTIL CODE PR MERGED)
stdalgos (10/N): team-level API, and rst update for release 4.2
Dec 10, 2023
fnrizzi
changed the title
stdalgos (10/N): team-level API, and rst update for release 4.2
stdalgos (10/10): team-level API, and rst update for release 4.2
Dec 10, 2023
fnrizzi
force-pushed
the
std_teamlevel_p10of10
branch
from
December 16, 2023 10:15
ae70ffe
to
8e43724
Compare
fnrizzi
force-pushed
the
std_teamlevel_p10of10
branch
from
December 19, 2023 16:53
141852d
to
28ce948
Compare
ajpowelsnl
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antoinemeyer5 , @fnrizzi , @crtrott -- Looks good; only potential (future) "gotcha" is the warning about methods being in Kokkos::Experimental
namespace. This "gotcha" will be true for a number of the std::algorithms
entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add team-level API to and convert to rst the following algorithms:
NOTE: this follows the new structure for documenting the API, but does not use sphinx because the lack of properly aligning things make things quite unreadable.
Open individual html with Firefox (must be firefox or it won't display correctly)