Apply check functions to fft functions #130
Merged
+189
−163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #80
This PR aims at replacing runtime
assert
withKOKKOSFFT_EXPECTS
. Adding morestatic_assertions
if applicable.Modifications are applied to source code under
fft/src
andfft/unit_test
.Following modifications are made
KOKKOSFFT_EXPECTS
fromKokkosFFT_utils.hpp
toKokkosFFT_asserts.hpp
are_valid_axes
function where it is applicableKOKKOSFFT_EXPECTS
to some if else conditional (throwstd::runtime_error
in the case ofelse
)is_complex<ViewType>::value
withis_complex_v<ViewType>