NRM1: refactoring TPL layer a bit with c++17 if constexpr

Hopefully this leads to simpler code, less duplication, less macro and easier maintenance! Adding support for oneapi MKL while making tpl layer changes.
kokkos · Nov 20, 2023 · 5948d04 · 5948d04
1 parent 5a36d57
commit 5948d04
Show file tree

Hide file tree

Showing 3 changed files with 335 additions and 479 deletions.
diff --git a/blas/tpls/KokkosBlas1_nrm1_tpl_spec_avail.hpp b/blas/tpls/KokkosBlas1_nrm1_tpl_spec_avail.hpp
@@ -113,6 +113,40 @@ KOKKOSBLAS1_NRM1_TPL_SPEC_AVAIL_ROCBLAS(Kokkos::complex<float>,
 
 #endif  // KOKKOSKERNELS_ENABLE_TPL_ROCBLAS
 
+// oneMKL
+#ifdef KOKKOSKERNELS_ENABLE_TPL_MKL
+
+#if defined(KOKKOS_ENABLE_SYCL) && \
+    !defined(KOKKOSKERNELS_ENABLE_TPL_MKL_SYCL_OVERRIDE)
+
+#define KOKKOSBLAS1_NRM1_TPL_SPEC_AVAIL_MKL_SYCL(SCALAR, LAYOUT, MEMSPACE)     \
+  template <class ExecSpace>                                                   \
+  struct nrm1_tpl_spec_avail<                                                  \
+      ExecSpace,                                                               \
+      Kokkos::View<                                                            \
+          typename Kokkos::Details::InnerProductSpaceTraits<SCALAR>::mag_type, \
+          LAYOUT, Kokkos::HostSpace,                                           \
+          Kokkos::MemoryTraits<Kokkos::Unmanaged> >,                           \
+      Kokkos::View<const SCALAR*, LAYOUT, Kokkos::Device<ExecSpace, MEMSPACE>, \
+                   Kokkos::MemoryTraits<Kokkos::Unmanaged> >,                  \
+      1> {                                                                     \
+    enum : bool { value = true };                                              \
+  };
+
+KOKKOSBLAS1_NRM1_TPL_SPEC_AVAIL_MKL_SYCL(
+    double, Kokkos::LayoutLeft, Kokkos::Experimental::SYCLDeviceUSMSpace)
+KOKKOSBLAS1_NRM1_TPL_SPEC_AVAIL_MKL_SYCL(
+    float, Kokkos::LayoutLeft, Kokkos::Experimental::SYCLDeviceUSMSpace)
+KOKKOSBLAS1_NRM1_TPL_SPEC_AVAIL_MKL_SYCL(
+    Kokkos::complex<double>, Kokkos::LayoutLeft,
+    Kokkos::Experimental::SYCLDeviceUSMSpace)
+KOKKOSBLAS1_NRM1_TPL_SPEC_AVAIL_MKL_SYCL(
+    Kokkos::complex<float>, Kokkos::LayoutLeft,
+    Kokkos::Experimental::SYCLDeviceUSMSpace)
+
+#endif  // KOKKOS_ENABLE_SYCL
+#endif  // KOKKOSKERNELS_ENABLE_TPL_MKL
+
 }  // namespace Impl
 }  // namespace KokkosBlas
 #endif