Replace KOKKOS_IMPL_DO_NOT_USE_PRINTF with Kokkos::printf #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
lucbv
requested changes
Aug 19, 2023
There was a problem hiding this comment.
@masterleinad since we are trying to keep backward compatibility with 4.0.0 can you add appropriate preprocessor guards for KOKKOS_VERSION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this release we are still keeping
KOKKOS_IMPL_DO_NOT_USE_PRINTFbut it's not clear when we are removing it, possibly after the next release.The original Kokkos pull request was kokkos/kokkos#6083.