Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODE - RK: fixing small issues reported by Yaro #2229

Merged
merged 10 commits into from
Nov 4, 2024
Merged

ODE - RK: fixing small issues reported by Yaro #2229

merged 10 commits into from
Nov 4, 2024

Commits on Nov 1, 2024

  1. ODE - RK: fixing small issues reported by Yaro 

    1. fix integer division to floating point division
2. fix evaluation of max scaled error
3. increase or decrease time step using uniform formula
4. use num_steps instead of max_steps for dt calculation
5. add a time step when using constant dt to avoid issues with round-off errors
6. fixing exponent and moving adaptivity computation out of RKStep
7. adding time step counter
8. adding more tests and keep track of time steps if wanted

Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    86e72d8 View commit details
    Browse the repository at this point in the history

  2. RK: fixing variable name after rebase 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    1770885 View commit details
    Browse the repository at this point in the history

  3. RK: enabling most methods after fixing test related issues 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    324b888 View commit details
    Browse the repository at this point in the history

  4. RK: passing new unit-tests 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    d69e511 View commit details
    Browse the repository at this point in the history

  5. Applying clang-format 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    709f14f View commit details
    Browse the repository at this point in the history

  6. RK: fix bad subview creation 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ca5e57f View commit details
    Browse the repository at this point in the history

  7. RK: fix bug that computes the inital step size for non-adaptive case 

    This prevents having the user defined time step and leads to
wrong results. The rate of convergence tests are now passing!

Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4a16b56 View commit details
    Browse the repository at this point in the history

  8. clang-format... 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c3a4e12 View commit details
    Browse the repository at this point in the history

  9. RK: tweaking the tolerances a bit 

    On GPU the lowest order method (RK1-2) is accumulating a bit more
errors than on CPU. Only an issue when comparing values to zero
where the absolute tolerance is needed to detect good conv.

Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7fe3fcd View commit details
    Browse the repository at this point in the history

  10. Adding reference for some implementation details and heuristic values 

    Signed-off-by: Luc Berger-Vergiat <[email protected]>
    @lucbv
    lucbv committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f5b9be8 View commit details
    Browse the repository at this point in the history