Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused FillSymmetricLowerEdgesHashMap::lower_only #2415

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

cwpearson
Copy link
Contributor

This field seems to be both unset and unused.

Possible fix for something caught in UB sanitizer.

@cwpearson cwpearson changed the title removeu unused FillSymmetricLowerEdgesHashMap::lower_only remove unused FillSymmetricLowerEdgesHashMap::lower_only Nov 5, 2024
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable

@cwpearson
Copy link
Contributor Author

It seems like this did fix one UB sanitizer error!

@lucbv lucbv merged commit 1f8809b into kokkos:develop Nov 5, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants