Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fused gtest v1.11.0 from Kokkos #2416

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

cwpearson
Copy link
Contributor

@cwpearson cwpearson commented Nov 5, 2024

I have included each change Kokkos made in its own commit, without comment or justification:

Looks like this version is a bit pickier about types in some comparisons.

@cwpearson cwpearson removed the AT: WIP label Nov 5, 2024
@cwpearson cwpearson marked this pull request as ready for review November 5, 2024 22:19
@cwpearson
Copy link
Contributor Author

@lucbv our format check just applies clang-format to every changed file, not a list of files in the repo, so it's expected to fail here since we don't format this vendored code.

@cwpearson cwpearson force-pushed the enhancement/gtest-1.11.0 branch 4 times, most recently from 9067ff2 to aa94896 Compare November 5, 2024 23:15
@lucbv lucbv merged commit 48b38fc into kokkos:develop Nov 6, 2024
19 of 21 checks passed
@ndellingwood
Copy link
Contributor

This will need one follow up to resolve some -Werror in Trilinos nightly integration builds, e.g.

/scratch/trilinos/workspace/Nightly/Trilinos_nightly_pipeline/Trilinos/kokkos-kernels/tpls/gtest/gtest/gtest.h:11427:11: error: comparison of integer expressions of different signedness: 'const long unsigned int' and 'const long int' [-Werror=sign-compare]
   if (lhs == rhs) {

https://trilinos-cdash.sandia.gov/viewBuildError.php?buildid=1952053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants