Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable PR tests which ran on sogpu01 at Sandia #2439

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

cwpearson
Copy link
Contributor

This machine has been repurposed.

@JBludau
Copy link

JBludau commented Nov 25, 2024

why not delete the lines instead of commenting out?

@jgfouca
Copy link
Contributor

jgfouca commented Nov 25, 2024

I think commenting out makes sense since we will likely be re-enabling v100 testing on some other machine soon.

@ndellingwood ndellingwood added the AT2-SPECIAL-APPROVAL Mark .github changes as approved. label Nov 25, 2024
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually looking at PR #2441 the Clang CI build seems to still be running correctly. We should keep it if possible.

@cwpearson
Copy link
Contributor Author

It was an oversight that that test continued to work. It was running on sogpu01 and I have disabled it since that machine will be used for something else.

@lucbv
Copy link
Contributor

lucbv commented Nov 26, 2024

Okay, if you can do a quick rebase for the update to kokkos 4.5.00 as version to test against then I can approve and we can merge this.

This job ran on sogpu01, which is now used for another purpose.

Signed-off-by: Carl Pearson <[email protected]>
These jobs ran on sogpu01, which is now used for another purpose.

Signed-off-by: Carl Pearson <[email protected]>
@lucbv lucbv merged commit 372c88f into kokkos:develop Nov 26, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT2-SPECIAL-APPROVAL Mark .github changes as approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants