fix padded layout annotations and add tagged raw array constructor to layout_stride
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmm0
commented
Apr 24, 2024
Comment on lines
+346
to
+357
| /* | ||
| * TODO: check preconditions | ||
| * - s[i] > 0 is true for all i in the range [0, rank_ ). | ||
| * - REQUIRED-SPAN-SIZE(e, s) is a representable value of type index_type ([basic.fundamental]). | ||
| * - If rank_ is greater than 0, then there exists a permutation P of the integers in the | ||
| * range [0, rank_), such that s[ pi ] >= s[ pi − 1 ] * e.extent( pi − 1 ) is true for | ||
| * all i in the range [1, rank_ ), where pi is the ith element of P. | ||
| */ |
There was a problem hiding this comment.
This TODO is just a copy and paste from the std::array constructor
nmm0
added a commit
to nmm0/kokkos
that referenced
this pull request
Apr 24, 2024
nmm0
added a commit
to nmm0/kokkos
that referenced
this pull request
May 1, 2024
crtrott
force-pushed
the
326-fix-padded-layout-annotations
branch
from
0940586
to
0ad1b26
Compare
crtrott
requested changes
May 3, 2024
| namespace MDSPAN_IMPL_STANDARD_NAMESPACE { | ||
| constexpr struct mdspan_non_standard_tag { | ||
| } mdspan_non_standard; | ||
| } // namespace MDSPAN_IMPL_STANDARD_NAMESPACE |
There was a problem hiding this comment.
This should go into the utility header introduced by the cpp14 support PR
nmm0
added a commit
to nmm0/kokkos
that referenced
this pull request
May 13, 2024
nmm0
added a commit
to nmm0/kokkos
that referenced
this pull request
May 15, 2024
… layouts and reformat code
… a raw array type as std::array is not compatible
nmm0
force-pushed
the
326-fix-padded-layout-annotations
branch
from
0ad1b26
to
f08661a
Compare
crtrott
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326
Additionally, some device code cannot use
std::arrayso this adds a "non-standard" constructor tolayout_stridethat accepts a raw array to support this use case