Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of zero-length carray #336

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

crtrott
Copy link
Member

@crtrott crtrott commented May 31, 2024

When compiling with pedantic there are various issues with the use of zero-length c-arrays. This PR is the result of my efforts to resolve this issue for all compilers in all C++ standard modes. In some combinations only some of the changes are needed, but to resolve all of them I needed all the changes presented here.

Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comments there too! : - )

Copy link
Contributor

@nmm0 nmm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@crtrott crtrott merged commit 18c332e into kokkos:stable Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants