Fix infinite recursion crash in gemm
cross-test
#222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In build with default Kokkos execution space (both
LINALG_ENABLE_KOKKOS
andLINALG_ENABLE_KOKKOS_DEFAULT
enabled) the nativegemm
test executes Kokkosmatrix_product()
implementation and fails on missing overloads fortransposed
- andscaled
-wrapped inputs - see #218.This PR fixes adds recursion detection to
is_custom_matrix_product_avail<...>
check allowing proper fallback to inline implementation, as proposed/explained in #218 (comment).