Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite recursion crash in gemm cross-test #222

Merged
merged 1 commit into from
May 27, 2022

Conversation

mzuzek
Copy link

@mzuzek mzuzek commented May 27, 2022

In build with default Kokkos execution space (both LINALG_ENABLE_KOKKOS and LINALG_ENABLE_KOKKOS_DEFAULT enabled) the native gemm test executes Kokkos matrix_product() implementation and fails on missing overloads for transposed- and scaled-wrapped inputs - see #218.

This PR fixes adds recursion detection to is_custom_matrix_product_avail<...> check allowing proper fallback to inline implementation, as proposed/explained in #218 (comment).

This PR offers alternative solution to #220 (disable test) as requested in #220 (comment)

@mzuzek mzuzek requested review from fnrizzi and mhoemmen May 27, 2022 09:52
@mzuzek
Copy link
Author

mzuzek commented May 27, 2022

@mhoemmen @fnrizzi
Should other checks be moved to the bottom of the file for consistency ?
(fixed version uses the dispatch, so can't be defined before it, unless we add forward declarations...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants