Skip to content

Commit

Permalink
Enhance: GitHub TEMPLATE 현지화
Browse files Browse the repository at this point in the history
  • Loading branch information
noridev committed Dec 7, 2023
1 parent ec05d88 commit fdcbb1e
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 14 deletions.
6 changes: 5 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/01_bug.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
<!-- ℹ お読みください / README
<!-- ℹ 읽어주세요 / お読みください / README
PR을 보내주셔서 감사합니다! PR을 작성하기 전에 기여 가이드를 먼저 확인해 주세요:
PRありがとうございます! PRを作成する前に、コントリビューションガイドをご確認ください:
Thank you for your PR! Before creating a PR, please check the contribution guide:
https://github.com/kokonect-link/cherrypick/blob/develop/CONTRIBUTING.md
-->

## What
<!-- 이 PR은 무엇을 변경하며, 어떻게 달라집니까? -->
<!-- このPRで何をしたのか? どう変わるのか? -->
<!-- What did you do with this PR? How will it change things? -->

## Why
<!-- 왜 그렇게 변경했나요? 어떤 의도인가요? 문제는 무엇인가요? -->
<!-- なぜそうするのか? どういう意図なのか? 何が困っているのか? -->
<!-- Why do you do it? What are your intentions? What is the problem? -->

## Additional info (optional)
<!-- 테스트 관점 등 -->
<!-- テスト観点など -->
<!-- Test perspective, etc -->

Expand Down
6 changes: 5 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/02_enhance.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
<!-- ℹ お読みください / README
<!-- ℹ 읽어주세요 / お読みください / README
PR을 보내주셔서 감사합니다! PR을 작성하기 전에 기여 가이드를 먼저 확인해 주세요:
PRありがとうございます! PRを作成する前に、コントリビューションガイドをご確認ください:
Thank you for your PR! Before creating a PR, please check the contribution guide:
https://github.com/kokonect-link/cherrypick/blob/develop/CONTRIBUTING.md
-->

## What
<!-- 이 PR은 무엇을 변경하며, 어떻게 달라집니까? -->
<!-- このPRで何をしたのか? どう変わるのか? -->
<!-- What did you do with this PR? How will it change things? -->

## Why
<!-- 왜 그렇게 변경했나요? 어떤 의도인가요? 문제는 무엇인가요? -->
<!-- なぜそうするのか? どういう意図なのか? 何が困っているのか? -->
<!-- Why do you do it? What are your intentions? What is the problem? -->

## Additional info (optional)
<!-- 테스트 관점 등 -->
<!-- テスト観点など -->
<!-- Test perspective, etc -->

Expand Down
20 changes: 10 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE/03_release.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ For more information on the release instructions, please see:
https://github.com/kokonect-link/cherrypick/blob/develop/CONTRIBUTING.md#release

## For reviewers
- CHANGELOGに抜け漏れは無いか
- バージョンの上げ方は適切か
- 他にこのリリースに含めなければならない変更は無いか
- 全体的な変更内容を俯瞰し問題は無いか
- レビューされていないコミットがある場合は、それが問題ないか
- 最終的な動作確認を行い問題は無いか
- CHANGELOG_CHERRYPICK에 누락된 부분은 없는가?
- 버전업 방법은 적절한가?
- 이 릴리스에 포함시켜야 할 다른 변경사항은 없는가?
- 전체적인 변경 내용을 비교하고 문제는 없는지
- 검토되지 않은 커밋이 있다면, 그것이 문제가 없는지
- 최종 동작을 확인하여 문제가 없는지

などを確認し、リリースする準備が整っていると思われる場合は approve してください。
등을 확인하고 출시할 준비가 되었다고 판단되면 approve 를 해주세요.

## Checklist
- [ ] package.jsonのバージョンが正しく更新されている
- [ ] CHANGELOGが過不足無く更新されている
- [ ] CIが全て通っている
- [ ] package.json의 버전이 올바르게 업데이트됨
- [ ] CHANGELOG_CHERRYPICK가 누락 또는 오류 없이 업데이트됨
- [ ] CI가 모두 통과됨
7 changes: 5 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,27 @@
<!-- ℹ お読みください / README
<!-- ℹ 읽어주세요 / お読みください / README
PR을 보내주셔서 감사합니다! PR을 작성하기 전에 기여 가이드를 먼저 확인해 주세요:
PRありがとうございます! PRを作成する前に、コントリビューションガイドをご確認ください:
Thank you for your PR! Before creating a PR, please check the contribution guide:
https://github.com/kokonect-link/cherrypick/blob/develop/CONTRIBUTING.md
-->

## What
<!-- 이 PR은 무엇을 변경하며, 어떻게 달라집니까? -->
<!-- このPRで何をしたのか? どう変わるのか? -->
<!-- What did you do with this PR? How will it change things? -->

## Why
<!-- 왜 그렇게 변경했나요? 어떤 의도인가요? 문제는 무엇인가요? -->
<!-- なぜそうするのか? どういう意図なのか? 何が困っているのか? -->
<!-- Why do you do it? What are your intentions? What is the problem? -->

## Additional info (optional)
<!-- 테스트 관점 등 -->
<!-- テスト観点など -->
<!-- Test perspective, etc -->

## Checklist
- [ ] Read the [contribution guide](https://github.com/kokonect-link/cherrypick/blob/develop/CONTRIBUTING.md)
- [ ] Test working in a local environment
- [ ] (If needed) Add story of storybook
- [ ] (If needed) Update CHANGELOG.md
- [ ] (If possible) Add tests

0 comments on commit fdcbb1e

Please sign in to comment.