Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renote visibility selector #400

Merged
merged 14 commits into from
Dec 18, 2023
Merged

Conversation

qwreey
Copy link
Contributor

@qwreey qwreey commented Dec 15, 2023

What

  • Add renote visibility selector.
  • Separate channel quote and normal quote when target note is in a channel

How it looks like

image image
(channel) QuoteSeparation + VisibilitySelector (channel) VisibilitySelector
image image
QuoteSeparation + VisibilitySelector VisibilitySelector
image image
Context menu for note which is in home Context menu for note which is public

user can enable or disable this option in settings like below
image

Separate channel quote and normal quote when target note is in a channel like below
image
Separate channel quote and normal quote when target note is in a channel

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 155 lines in your changes are missing coverage. Please review.

Comparison is base (214047c) 82.24% compared to head (8e0d577) 81.78%.

Files Patch % Lines
packages/frontend/src/scripts/get-note-menu.ts 2.73% 142 Missing ⚠️
.../src/scripts/add-dividers-between-menu-sections.ts 23.52% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #400      +/-   ##
===========================================
- Coverage    82.24%   81.78%   -0.46%     
===========================================
  Files          189      188       -1     
  Lines        31044    30976      -68     
  Branches       528      528              
===========================================
- Hits         25531    25333     -198     
- Misses        5513     5643     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwreey qwreey changed the title Renote visibility Renote visibility selector Dec 15, 2023
@kdh8219
Copy link

kdh8219 commented Dec 16, 2023

Locale 추가하셨던데, 파이어피시는 이렇게 구현해놨더라고요
https://git.joinfirefish.org/firefish/firefish/-/blob/develop/packages/client/src/components/MkRenoteButton.vue?ref_type=heads#L121
이렇게 하면 Locale 더 추가 안하고 작업 가능한데 이 방안은 어떻게 생각하세요?

@qwreey
Copy link
Contributor Author

qwreey commented Dec 16, 2023

image
사견이긴 하지만, 저렇게 Boost Boost Boost (체리픽에선 리노트 리노트 리노트 리노트) 라고 첫글자가 다 같은게 조금 이쁘게 보이지가 않아서 로케일을 추가한거긴 해요
노리데브씨가 맘에 드는데로 바꾸는걸로 하죠..?

@qwreey
Copy link
Contributor Author

qwreey commented Dec 16, 2023

우선 @caipira113 씨 의견으로썬 공개범위가 다 따로 이미 번역되어있기 때문에 그거 끌어다 쓰는것도 괜찮을것 같다 해서 음
그렇게 구현하죠? (이렇게 하자는 사람 많기도 하고 로케일 돌려쓰기가 편한건 사실이라 읍읍)

@qwreey
Copy link
Contributor Author

qwreey commented Dec 16, 2023

일단 테스트상으론 문제를 찾지 못했어요. 아마 잘 되는듯 합니다
image

@qwreey
Copy link
Contributor Author

qwreey commented Dec 16, 2023

image
image

Quote 나눠버리기를 하면 단순 리노트만 두개를 분리해놓는 상황이라 합치기를 했는데, 이게 합쳐지는게 채널이 아래쪽으로 가는게 맞겠네요 수정을 해야겠어요

@qwreey qwreey marked this pull request as ready for review December 16, 2023 02:07
@noridev noridev self-requested a review December 18, 2023 08:42
@noridev noridev merged commit 3b2ffa1 into kokonect-link:develop Dec 18, 2023
12 of 15 checks passed
@noridev
Copy link
Collaborator

noridev commented Dec 18, 2023

🙏🙏

@noridev noridev mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants