Let launcher choose debug icon when running in non-prod (#1014)

kolide · Feb 6, 2023 · 1095f6f · 1095f6f
1 parent c0e0cdb
commit 1095f6f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/ee/desktop/menu/menu.go b/ee/desktop/menu/menu.go
@@ -14,8 +14,7 @@ import (
 type menuIcon string
 
 const (
-	KolideDesktopIcon      = "kolide-desktop"
-	KolideDebugDesktopIcon = "kolide-debug-desktop"
+	KolideDesktopIcon = "kolide-desktop"
 )
 
 // MenuData encapsulates a menu bar icon and accessible menu items

diff --git a/ee/desktop/menu/menu_parse_test.go b/ee/desktop/menu/menu_parse_test.go
@@ -63,7 +63,7 @@ func Test_ParseMenuData(t *testing.T) {
 		{
 			name: "happy path",
 			data: &MenuData{
-				Icon:    KolideDebugDesktopIcon,
+				Icon:    KolideDesktopIcon,
 				Tooltip: "Kolide",
 			},
 		},

diff --git a/ee/desktop/menu/menu_systray.go b/ee/desktop/menu/menu_systray.go
@@ -46,9 +46,12 @@ func (m *menu) Build() {
 func (m *menu) SetIcon(icon menuIcon) {
 	switch icon {
 	case KolideDesktopIcon:
-		systray.SetTemplateIcon(assets.KolideDesktopIcon, assets.KolideDesktopIcon)
-	case KolideDebugDesktopIcon:
-		systray.SetTemplateIcon(assets.KolideDebugDesktopIcon, assets.KolideDebugDesktopIcon)
+		// Allow launcher to conditionally choose the launcher icon based on whether we're running in production or not
+		if m.isProd() {
+			systray.SetTemplateIcon(assets.KolideDesktopIcon, assets.KolideDesktopIcon)
+		} else {
+			systray.SetTemplateIcon(assets.KolideDebugDesktopIcon, assets.KolideDebugDesktopIcon)
+		}
 	default:
 		level.Debug(m.logger).Log(
 			"msg", "invalid icon",