Skip to content

Commit

Permalink
Fix the values not considered correctly when loading the upgrade preview
Browse files Browse the repository at this point in the history
  • Loading branch information
undera committed Feb 22, 2023
1 parent a7c7ba8 commit 778e583
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 4 additions & 2 deletions pkg/dashboard/static/actions.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@ function popUpUpgrade(elm, ns, name, verCur, lastRev) {
$('#upgradeModal select').append(opt)
}

$('#upgradeModal select').val(elm.version).trigger("change").parent().show()
$('#upgradeModal select').val(elm.version).parent().show()
upgrPopUpCommon(verCur, ns, lastRev, name)
})
} else { // chart without repo reconfigure
$('#upgradeModal select').empty().trigger("change").parent().hide()
$('#upgradeModal select').empty().parent().hide()
upgrPopUpCommon(verCur, ns, lastRev, name)
}
}
Expand All @@ -121,9 +121,11 @@ function upgrPopUpCommon(verCur, ns, lastRev, name) {
reportError("Failed to get charts values info", xhr)
}).done(function (data) {
$("#upgradeModal textarea").val(data).data("dirty", false)
$('#upgradeModal select').trigger("change")
})
} else {
$("#upgradeModal textarea").val("").data("dirty", true)
$('#upgradeModal select').trigger("change")
}
}

Expand Down
3 changes: 1 addition & 2 deletions pkg/dashboard/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@
</li>
<li class="nav-item mx-2 display-none upgrade-possible">
<a class="nav-link position-relative text-danger"
href="https://github.com/komodorio/helm-dashboard#installing" target="_blank">
href="https://github.com/komodorio/helm-dashboard/releases" target="_blank">
Upgrade to <span id="toolVersionUpgrade"></span>
</a></li>

</ul>
<div>
<a class="btn" href="https://komodor.com/?utm_campaign=Helm-Dash&utm_source=helm-dash"><img
Expand Down

0 comments on commit 778e583

Please sign in to comment.