Merge branch 'main' of github.com:komodorio/helm-dashboard

komodorio · Dec 19, 2022 · e9abedb · e9abedb
2 parents 5d0a148 + c0cf623
commit e9abedb
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -60,7 +60,7 @@ jobs:
 
   image:
     runs-on: ubuntu-latest
-    needs: release
+    needs: [release, pre_release]
     timeout-minutes: 60
     steps:
       - name: Check out the repo
@@ -85,13 +85,13 @@ jobs:
         with:
           context: .
           push: ${{ github.event_name != 'pull_request' }}
-          tags: ${{ needs.pre_release.outputs.release_tag }}
+          tags: komodorio/helm-dashboard:${{ needs.pre_release.outputs.release_tag }},komodorio/helm-dashboard:latest
           labels: ${{ steps.meta.outputs.labels }}
           build-args: VER=${{ needs.pre_release.outputs.release_tag }}
 
   publish_chart:
     runs-on: ubuntu-latest
-    need: image
+    needs: [image, pre_release]
     if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
     steps:
       - name: Checkout

diff --git a/charts/helm-dashboard/Chart.yaml b/charts/helm-dashboard/Chart.yaml
@@ -3,7 +3,7 @@ type: application
 
 name: helm-dashboard
 description: A GUI Dashboard for Helm by Komodor
-icon: "https://github.com/komodorio/helm-dashboard/blob/main/pkg/dashboard/static/logo.png"
+icon: "https://raw.githubusercontent.com/komodorio/helm-dashboard/main/pkg/dashboard/static/logo.svg"
 
 version: 0.1.1
-appVersion: "0.3.0" 
+appVersion: "0.3.0"
diff --git a/charts/helm-dashboard/README.md b/charts/helm-dashboard/README.md
@@ -49,7 +49,7 @@ The following table lists the configurable parameters of the chart and their def
 | `image.tag`                          | Image tag                                                                                      |                                      |
 | `image.pullPolicy`                   | Image pull policy                                                                              | `IfNotPresent`                       |
 | `replicaCount`                       | Number of dashboard Pods to run                                                                | `1`                                  |
-| `dashboard.allowWriteActions`        | Enables write actions. Allow modifying, deleting and creating charts and kubernetes resources. | `false`                              |
+| `dashboard.allowWriteActions`        | Enables write actions. Allow modifying, deleting and creating charts and kubernetes resources. | `true`                               |
 | `resources.requests.cpu`             | CPU resource requests                                                                          | `200m`                               |
 | `resources.limits.cpu`               | CPU resource limits                                                                            | `1`                                  |
 | `resources.requests.memory`          | Memory resource requests                                                                       | `256Mi`                              |

diff --git a/charts/helm-dashboard/templates/serviceaccount.yaml b/charts/helm-dashboard/templates/serviceaccount.yaml
@@ -17,11 +17,11 @@ apiVersion: rbac.authorization.k8s.io/v1
 metadata:
   name: {{ include "helm-dashboard.serviceAccountName" . }}
 rules:
-  - apiGroups: ["", "apps", "rbac.authorization.k8s.io", "rbac", "batch", "extensions", "networking.k8s.io", "storage.k8s.io"]
+  - apiGroups: ["*"]
     resources: ["*"]
     verbs: ["get", "list", "watch"]
   {{- if .Values.dashboard.allowWriteActions }}
-  - apiGroups: ["", "apps", "rbac.authorization.k8s.io", "rbac", "batch", "extensions", "networking.k8s.io", "storage.k8s.io"]
+  - apiGroups: ["*"]
     resources: ["*"]
     verbs: ["get", "list", "watch", "create", "delete", "patch", "update"]
   {{- end }}

diff --git a/charts/helm-dashboard/values.yaml b/charts/helm-dashboard/values.yaml
@@ -26,7 +26,7 @@ resources:
     memory: 1Gi
 
 dashboard:
-  allowWriteActions: false
+  allowWriteActions: true
   persistence:
     enabled: true