Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use --dry-run=server to make lookup work properly while diff #501

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

iiiceoo
Copy link
Contributor

@iiiceoo iiiceoo commented Jan 22, 2024

Changes Proposed

  • Bump helm client to v3.13.3.
  • Use --dry-run=server to make lookup work properly while diff.

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

@iiiceoo
Copy link
Contributor Author

iiiceoo commented Jan 22, 2024

/cc @undera

Copy link
Collaborator

@undera undera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iiiceoo Something gets broken in unit tests with this change, please take a look

@iiiceoo iiiceoo changed the title feat: Use --dry-run=server to make lookup work properly while diff WIP: Use --dry-run=server to make lookup work properly while diff Jan 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9481c9a) 29.96% compared to head (5a9a80e) 29.84%.

Files Patch % Lines
pkg/dashboard/objects/releases.go 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   29.96%   29.84%   -0.12%     
==========================================
  Files          10       10              
  Lines        1325     1330       +5     
==========================================
  Hits          397      397              
- Misses        887      892       +5     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iiiceoo iiiceoo requested a review from undera January 23, 2024 03:24
@iiiceoo iiiceoo changed the title WIP: Use --dry-run=server to make lookup work properly while diff feat: Use --dry-run=server to make lookup work properly while diff Jan 23, 2024
@iiiceoo
Copy link
Contributor Author

iiiceoo commented Jan 23, 2024

/cc @undera

@undera
Copy link
Collaborator

undera commented Jan 23, 2024

Thanks!

@undera undera merged commit e954b7a into komodorio:main Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants