Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: history-max does not work when exec helm upgrade #507

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

iiiceoo
Copy link
Contributor

@iiiceoo iiiceoo commented Feb 2, 2024

Changes Proposed

Changes made in #500 did not work properly because the local variable --history-max of the cmd helm upgrade has a higher priority than the global one.

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

@iiiceoo
Copy link
Contributor Author

iiiceoo commented Feb 2, 2024

/cc @undera

@github-actions github-actions bot added the app label Feb 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6a7cade) 29.84% compared to head (e029652) 29.72%.

Files Patch % Lines
pkg/dashboard/objects/releases.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   29.84%   29.72%   -0.13%     
==========================================
  Files          10       10              
  Lines        1330     1329       -1     
==========================================
- Hits          397      395       -2     
- Misses        892      893       +1     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undera undera merged commit f7e92f1 into komodorio:main Feb 2, 2024
4 checks passed
@undera
Copy link
Collaborator

undera commented Feb 2, 2024

Does new version with ReactJS frontend work well for you @iiiceoo ?

@iiiceoo
Copy link
Contributor Author

iiiceoo commented Feb 4, 2024

If it refers to the changes involved in this PR, then the frontend is working well. Only 10 release are always displayed in the UI.

@iiiceoo iiiceoo deleted the max-hist branch February 4, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants