Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sast-coverity-check: added stats for Coverity scans #1693

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

jperezdealgaba
Copy link
Contributor

Solves: https://issues.redhat.com/browse/OSH-769

Adding the stats to Coverity scans in the result's SARIF file of successful scans.

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@openshift-ci openshift-ci bot requested review from jsztuka and kdudka December 5, 2024 14:02
@jperezdealgaba
Copy link
Contributor Author

This MR was discussed here: jperezdealgaba#4
and we were waiting for #1411 to be merged to create this MR

@jperezdealgaba jperezdealgaba force-pushed the cov-stats branch 2 times, most recently from edece1a to b28adb5 Compare December 6, 2024 10:25
@jperezdealgaba
Copy link
Contributor Author

@tnevrlka Would you mind enabling this pipeline please?

@tnevrlka
Copy link
Contributor

tnevrlka commented Dec 6, 2024

/ok-to-test

@jperezdealgaba
Copy link
Contributor Author

@dirgim Would you mind revieweing this? It is very related with: #1633

Copy link
Contributor

@kdudka kdudka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Solves: https://issues.redhat.com/browse/OSH-769

Adding the stats to Coverity scans in the result's SARIF file of successful scans.
@kdudka
Copy link
Contributor

kdudka commented Dec 9, 2024

/ok-to-test

@kdudka
Copy link
Contributor

kdudka commented Dec 9, 2024

@kasemAlem @dirgim Could you please check what happened that e2e-tests failed like this?

365 Skipped
--- FAIL: TestE2E (5476.37s)
FAIL

I do not have access to the corresponding logs myself.

@kasemAlem
Copy link
Contributor

kasemAlem commented Dec 9, 2024

@kasemAlem @dirgim Could you please check what happened that e2e-tests failed like this?

365 Skipped
--- FAIL: TestE2E (5476.37s)
FAIL

I do not have access to the corresponding logs myself.

@kdudka Seems like the PLR logs are removed , can I rebase and rerun then we follow result ?

@kdudka
Copy link
Contributor

kdudka commented Dec 9, 2024

@kasemAlem Yes, please. Note that I rebased this pull request 4 hours ago. It did not help.

@kasemAlem
Copy link
Contributor

LGTM

@kasemAlem
Copy link
Contributor

/ok-to-test

@kasemAlem kasemAlem added this pull request to the merge queue Dec 10, 2024
Merged via the queue into konflux-ci:main with commit 9fcc532 Dec 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants