Set useful SBOM name for rpm-ostree generated images #1739
Conversation
…@digest`of the pushed image. JIRA: ISV-5322 Signed-off-by: John Bell <[email protected]>
|
CI failure looks unrelated (looks like this repo could use https://github.com/redhat-plumbers-in-action/differential-shellcheck or honestly just less shell script) I see the task is cloned for a lot of repos, typically changes like this should mirror the buildah task, was that already done? |
Fun fact: checkton is differential-shellcheck, just for bash-in-yaml. If it wasn't, there would be 1241 shellcheck warnings and 13 errors in this repo. In this case, the change surfaces an existing warning because it changes the line the warning was on. |
…@digest`of the pushed image. (added quotes to prevent word splitting, per shellcheck warning) JIRA: ISV-5322 Signed-off-by: John Bell <[email protected]>
…@digest`of the pushed image. (updated task/rpm-ostree-oci-ta/0.2/rpm-ostree-oci-ta.yaml via hack/generate-ta-tasks.sh) JIRA: ISV-5322 Signed-off-by: John Bell <[email protected]>
|
@cgwalters I've updated and fixed the previous issue, PTAL |
There was a problem hiding this comment.
Looks sane to me.
Worth noting here we're actively trying to deprecate (and eventually remove) this task, xref https://issues.redhat.com/browse/BIFROST-408
|
On a procedural note, I doubt anyone else here cares but personally I would avoid merging from main into the branch for trivial patches like this, I'd rebase instead, it'd be a single commit with a single line change. |
|
/ok-to-test |
Set SBOM name for rpm-ostree generated images to
registry/repository@digestof the pushed image.JIRA: ISV-5322