Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-1199): fbc release e2e should contain the test for staged #1436

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Oct 22, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@jinqi7
Copy link
Contributor Author

jinqi7 commented Oct 22, 2024

/retest

2 similar comments
@jinqi7
Copy link
Contributor Author

jinqi7 commented Oct 23, 2024

/retest

@jinqi7
Copy link
Contributor Author

jinqi7 commented Oct 23, 2024

/retest

@jinqi7 jinqi7 requested a review from a team October 23, 2024 11:40
@jinqi7
Copy link
Contributor Author

jinqi7 commented Nov 5, 2024

/retest

@jinqi7 jinqi7 requested a review from theflockers November 7, 2024 07:53
@jinqi7
Copy link
Contributor Author

jinqi7 commented Nov 13, 2024

/retest

Copy link
Contributor

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theflockers can you take a look at this one?

@jinqi7 jinqi7 force-pushed the RELEASE-1199 branch 2 times, most recently from 5432a97 to 2f5888e Compare November 13, 2024 19:53
@johnbieren
Copy link
Contributor

@theflockers can you take a look here please?

@theflockers
Copy link
Contributor

theflockers commented Nov 26, 2024

@theflockers can you take a look here please?

sorry the delay @jinqi7 @johnbieren . I left a comment.

Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: theflockers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnbieren
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a9824c8 into konflux-ci:main Nov 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants