Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KONFLUX-4319): Capture Application & Component JSONs after load test #1459

Conversation

rh-rahulshetty
Copy link
Collaborator

Description

Application and Component JSON definitions were not being captured during load test execution because the objects were cleared when the --purge flag was set.

This PR addresses the issue by moving the collection of Application and Component JSON definitions to the component handler level.

Issue ticket number and link

https://issues.redhat.com/browse/KONFLUX-4319

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The changes have been tested successfully on Hive OpenShift cluster.

# On Hive cluster - setup & install Konflux
source user.env 
./tests/load-tests/ci-scripts/setup-cluster.sh

# Run Load test
export COMPONENT_REPO=https://github.com/rh-perf-test-org/devfile-sample CONCURRENCY=1 APPLICATIONS_COUNT=2 COMPONENTS_COUNT=2
./tests/load-tests/ci-scripts/load-test.sh

At end of the load test, we should be able to find collected-application-*.json and collected-component-*.json files with the object definition for Applications and Components created during the load test.

app(2)   component (4)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link
Collaborator

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 766cb58 into konflux-ci:main Nov 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants