feat(STONEINTG-702): add tests for integration pipeline re-runs #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test redhat-appstudio-e2e |
dirgim
changed the title
dirgim
force-pushed
the
STONEINTG-702
branch
from
bfa034b to
e14402a
Compare
|
/test redhat-appstudio-e2e |
dirgim
force-pushed
the
STONEINTG-702
branch
from
e14402a to
e10d907
Compare
|
/test redhat-appstudio-e2e |
dirgim
force-pushed
the
STONEINTG-702
branch
from
e10d907 to
1754d9b
Compare
|
/test redhat-appstudio-e2e |
dirgim
requested review from
MartinBasti and
psturc
and removed request for
MartinBasti
dheerajodha
reviewed
Dec 13, 2023
dirgim
force-pushed
the
STONEINTG-702
branch
from
590dc0d to
59e7501
Compare
psturc
requested changes
Dec 13, 2023
dirgim
force-pushed
the
STONEINTG-702
branch
from
59e7501 to
e80d71f
Compare
MartinBasti
approved these changes
Dec 13, 2023
|
/test redhat-appstudio-e2e |
kasemAlem
reviewed
Dec 13, 2023
dirgim
force-pushed
the
STONEINTG-702
branch
from
e80d71f to
3237860
Compare
|
/test redhat-appstudio-e2e |
dheerajodha
reviewed
Dec 13, 2023
dirgim
force-pushed
the
STONEINTG-702
branch
from
3237860 to
681ee7c
Compare
jsztuka
reviewed
Dec 14, 2023
| Expect(metadata.GetLabelsWithPrefix(updatedSnapshot, snapshotRerunLabel)).NotTo(BeEmpty()) | ||
| }) | ||
|
|
||
| When("An snapshot is updated with a rerun label for a given scenario", func() { |
There was a problem hiding this comment.
nit: I see re-run in previous It statement, should we unify this?
I'm for team re-run.
There was a problem hiding this comment.
Ack, updated to use re-run everywhere.
* The integration service recreates a new Integration PipelineRun based on the value of the test.appstudio.openshift.io/run=<ITSName> label on a Snapshot * This change adds e2e tests for the new functionality by adding the label in integration e2e tests and observing the retriggered pipelineRun is handled correctly Signed-off-by: dirgim <[email protected]>
* This change adds e2e tests for the new functionality by adding the label in integration namespace-backed environment e2e tests and observing the retriggered pipelineRun is handled correctly Signed-off-by: dirgim <[email protected]>
dirgim
force-pushed
the
STONEINTG-702
branch
from
681ee7c to
12796ff
Compare
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsztuka, MartinBasti, psturc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: