test: verify multiplatform cleanup #960
Conversation
stuartwdouglas
force-pushed
the
multiplatform-cleanup
branch
from
68eb4df to
0e5fed7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stuartwdouglas
force-pushed
the
multiplatform-cleanup
branch
4 times, most recently
from
91323fc to
e40a687
Compare
|
/retest |
|
/lgtm |
| userDir = string(userDirTmp) | ||
| hostParts := strings.Split(string(fullHost), "@") | ||
| host = strings.TrimSpace(hostParts[1]) | ||
| }) |
There was a problem hiding this comment.
Was there supposed to be some check for the userDir and host?
There was a problem hiding this comment.
no, we use the host for the SSH connection, then verify that the userDir does not exist as it has been cleaned up.
There was a problem hiding this comment.
Hmm, ok. It looks very wrong, could you at least add a comment that these are set here only so that the other It node can use them?
|
/retest |
|
Another failure in an unrelated test suite |
|
/retest |
This is needed for STONEBLD-1779 to verify we are not leaving credentials on the remote host
stuartwdouglas
force-pushed
the
multiplatform-cleanup
branch
from
e40a687 to
bc695dd
Compare
|
New changes are detected. LGTM label has been removed. |
|
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mmorhun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is needed for STONEBLD-1779 to verify we are not leaving credentials on the remote host
Description
Verifies that after a multi platform build the cleanup is successful.
Issue ticket number and link
https://issues.redhat.com/browse/STONEBLD-1779