-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(STONEINTG-704): e2e tests should check if the finalizer is removed from Integration PLRs #966
fix(STONEINTG-704): e2e tests should check if the finalizer is removed from Integration PLRs #966
Conversation
Skipping CI for Draft Pull Request. |
6cf44b7
to
10cd090
Compare
/retest |
10cd090
to
53e78ff
Compare
After this commit, we are now checking if the finalizer gets removed succesfully from all the Integration PLRs related to the given Application, after the integration has marked the snapshot as passed/failed AND reported the test results back to the status annotation of the snapshot. Signed-off-by: Dheeraj<[email protected]>
53e78ff
to
c3fa2ab
Compare
/test redhat-appstudio-e2e |
* and also update the GoDoc for a function Signed-off-by: Dheeraj<[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
/retest |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dirgim, kasemAlem, MartinBasti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
since it failed on un able to collect log of pod, known issue , will retest |
/test redhat-appstudio-e2e |
2 similar comments
/test redhat-appstudio-e2e |
/test redhat-appstudio-e2e |
Description
The integration service removes the finalizers from the Integration Pipelineruns after its test results are reported to the Snapshot and the overall test result is used to mark the Snapshot as Passed/Failed. So, this PR updates the current test suites to test this behaviour.
Issue ticket number and link
STONEINTG-704
Type of change
How Has This Been Tested?
I've tested this code locally and the test suite passed 10/10 times.
Checklist: