Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(STONEINTG-704): e2e tests should check if the finalizer is removed from Integration PLRs #966

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

dheerajodha
Copy link
Member

@dheerajodha dheerajodha commented Dec 18, 2023

Description

The integration service removes the finalizers from the Integration Pipelineruns after its test results are reported to the Snapshot and the overall test result is used to mark the Snapshot as Passed/Failed. So, this PR updates the current test suites to test this behaviour.

Issue ticket number and link

STONEINTG-704

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I've tested this code locally and the test suite passed 10/10 times.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Dec 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dheerajodha
Copy link
Member Author

/retest

@dheerajodha dheerajodha marked this pull request as ready for review December 26, 2023 13:23
After this commit, we are now checking if the finalizer gets
removed succesfully from all the Integration PLRs related to
the given Application, after the integration has marked the
snapshot as passed/failed AND reported the test results back
to the status annotation of the snapshot.

Signed-off-by: Dheeraj<[email protected]>
@dheerajodha
Copy link
Member Author

/test redhat-appstudio-e2e

@dheerajodha dheerajodha requested review from dirgim and jsztuka January 2, 2024 09:50
* and also update the GoDoc for a function

Signed-off-by: Dheeraj<[email protected]>
Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dheerajodha
Copy link
Member Author

/retest

@dheerajodha
Copy link
Member Author

/test all

@openshift-ci openshift-ci bot added the approved label Jan 8, 2024
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dirgim, kasemAlem, MartinBasti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasemAlem
Copy link
Contributor

since it failed on un able to collect log of pod, known issue , will retest

@kasemAlem
Copy link
Contributor

/test redhat-appstudio-e2e

2 similar comments
@dheerajodha
Copy link
Member Author

/test redhat-appstudio-e2e

@dheerajodha
Copy link
Member Author

/test redhat-appstudio-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit dbac092 into konflux-ci:main Jan 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants