Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(STONEINTG-702): remove check for successful Snapshot after re-run #967

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

dirgim
Copy link
Contributor

@dirgim dirgim commented Dec 18, 2023

  • The re-run integration test doesn't need to succeed in order to test the re-run functionality. Running multiple namespace-backed environment integration tests can run into resource limitations, failing the test.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

* The re-run integration test doesn't need to succeed in order to
  test the re-run functionality. Running multiple namespace-backed
  environment integration tests can run into resource limitations,
  failing the test.

Signed-off-by: dirgim <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@dirgim dirgim requested a review from MartinBasti December 18, 2023 10:39
Copy link
Member

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dheerajodha
Copy link
Member

dheerajodha commented Dec 18, 2023

failed with RHTAPBUGS-1009
/test redhat-appstudio-e2e

Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dheerajodha, hongweiliu17, kasemAlem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dheerajodha,kasemAlem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 63dacff into konflux-ci:main Dec 18, 2023
13 checks passed
jinqi7 pushed a commit to jinqi7/e2e-tests that referenced this pull request Dec 21, 2023
…konflux-ci#967)

* The re-run integration test doesn't need to succeed in order to
  test the re-run functionality. Running multiple namespace-backed
  environment integration tests can run into resource limitations,
  failing the test.

Signed-off-by: dirgim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants