fix(KFLUXBUGS-96): make the secret forms more clear

konflux-ci · Nov 25, 2024 · a436684 · a436684
1 parent b082a43
commit a436684
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/src/components/Secrets/SecretForm.tsx b/src/components/Secrets/SecretForm.tsx
@@ -71,7 +71,7 @@ const SecretForm: React.FC<React.PropsWithChildren<SecretFormProps>> = ({ existi
         required
         key={values.type}
         name="secretName"
-        label="Select or enter name"
+        label="Select or enter secret name"
         helpText="Unique name of the new secret."
         isCreatable
         isInputValuePersisted

diff --git a/src/components/Secrets/SecretsForm/SecretTypeSubForm.tsx b/src/components/Secrets/SecretsForm/SecretTypeSubForm.tsx
@@ -116,11 +116,10 @@ export const SecretTypeSubForm: React.FC<React.PropsWithChildren<unknown>> = ()
       {isPartnerTaskAvailable(currentTypeRef.current) ? (
         <SelectInputField
           name="name"
-          label="Secret name"
-          toggleAriaLabel="Secret name"
+          label="Select or enter secret name"
+          toggleAriaLabel="Select or enter secret name"
           helpText="Unique name of the new secret"
           toggleId="secret-name-toggle"
-          placeholderText="Enter name"
           variant={SelectVariant.typeahead}
           options={options}
           isCreatable

diff --git a/src/components/Secrets/__tests___/AddSecretForm.spec.tsx b/src/components/Secrets/__tests___/AddSecretForm.spec.tsx
@@ -49,7 +49,7 @@ describe('AddSecretForm', () => {
 
     await waitFor(() => {
       screen.getByText('Secret type');
-      screen.getByText('Secret name');
+      screen.getByText('Select or enter secret name');
       screen.getByText('Labels');
     });
   });

diff --git a/src/components/Secrets/__tests___/SecretTypeSubForm.spec.tsx b/src/components/Secrets/__tests___/SecretTypeSubForm.spec.tsx
@@ -43,7 +43,7 @@ describe('SecretTypeSubForm', () => {
 
   it('should render Secret type sub form and fields', () => {
     expect(screen.getByText('Secret type')).toBeVisible();
-    expect(screen.getByText('Secret name')).toBeVisible();
+    expect(screen.getByText('Select or enter secret name')).toBeVisible();
   });
 
   it('should render subforms correctly for specified targets', async () => {
@@ -57,8 +57,8 @@ describe('SecretTypeSubForm', () => {
   });
 
   it('should render correct variant of name field', () => {
-    expect(screen.getByRole('button', { name: 'Secret name' })).toBeVisible();
-    fireEvent.click(screen.getByRole('button', { name: 'Secret name' }));
+    expect(screen.getByRole('button', { name: 'Select or enter secret name' })).toBeVisible();
+    fireEvent.click(screen.getByRole('button', { name: 'Select or enter secret name' }));
     expect(screen.getByText('snyk-secret')).toBeVisible();
   });
 });