Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KFLUXUI-191): allow users to set context #25

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

CryptoRodeo
Copy link
Contributor

Allows users to set context values, both in the edit and create integration page.

By default the 'application' context should be selected when creating a new integration test.

Backport of openshift/hac-dev#997

@CryptoRodeo CryptoRodeo force-pushed the kfluxui-191 branch 2 times, most recently from c6f1dba to e3df816 Compare November 19, 2024 21:13
@CryptoRodeo CryptoRodeo marked this pull request as ready for review November 20, 2024 13:26
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 90.86294% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (850c442) to head (9ab84de).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
.../components/IntegrationTests/ContextSelectList.tsx 89.36% 10 Missing ⚠️
src/components/IntegrationTests/ContextsField.tsx 90.62% 6 Missing ⚠️
...nTests/IntegrationTestForm/IntegrationTestView.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   79.61%   79.72%   +0.11%     
==========================================
  Files         564      567       +3     
  Lines       20991    21200     +209     
  Branches     5200     5263      +63     
==========================================
+ Hits        16712    16902     +190     
- Misses       4254     4274      +20     
+ Partials       25       24       -1     
Flag Coverage Δ
unittests 79.72% <90.86%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Allows users to set context values, both in the edit
and create integration page.

By default the 'application' context should be selected
when creating a new integration test.
@CryptoRodeo
Copy link
Contributor Author

Code coverage should be safe to ignore, based on what I've seen. Most of the lines it's complaining about were not added in this PR.

Other lines don't seem to make sense, for example it complains about this line:

export const ContextSelectList: React.FC<ContextSelectListProps> = ({

Yet that component is imported for it's spec test: https://github.com/konflux-ci/konflux-ui/pull/25/files#diff-bafded342a2a58bdb6604e41999d92487b1389c783dad27db3f76713604c87ffR3

@sahil143 sahil143 merged commit e7df589 into konflux-ci:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants