-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templating Update #358
Open
dahendel
wants to merge
23
commits into
konstructio:main
Choose a base branch
from
dahendel:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Templating Update #358
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
77c6544
Refactor, add CustomTemplateValues support
dahendel 1c473cc
Refactor to use renderGoTemplating function
dahendel 84ff1c2
Add new template-based detokenization logic
dahendel a478882
``` Refactor detokenize logic; remove redundant code ```
dahendel 9f2e7ce
Remove unused toTemplateVariable function
dahendel 3c5bd70
go fmt
dahendel 96bef4f
Adding some code comments
dahendel 98eb9b8
complete test suite and fixes
dahendel d0faba8
updated delims to not conflict with Terraform <<EOT, more tests
dahendel 60e8ebd
refactor detokenize to handle gitops and metaphor
dahendel a6eb775
add optional cleanup step based on K1_TEST_CLEANUP
dahendel 0a5e2c6
Merge branch 'main' into main
dahendel b1040e0
add toJson func for templating
dahendel c886ff8
chore: bump gitops template version (#366)
CristhianF7 20fd38a
[skip ci] [CI SKIP] setting kubefirst-api production to chart version…
a228198
fix : timeout issue for argocd and vault for public clouds (#363)
jokestax 10455f9
go.mod dep update
dahendel d75f6fb
fmt
dahendel 548959a
Merge remote-tracking branch 'upstream/main'
dahendel ef3bd8a
update doc comment on return statement ToTemplateVars
dahendel ffe250f
addressing pr comments
dahendel 5a69273
Update repo URL and add directory existence check
dahendel 6a02964
correct a DetokenizeGitGitops Call from services
dahendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with the rest of the team, we want to go with these for delimiters: