Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): make the dns resource group optional #2339

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Nov 28, 2024

Description

This makes the resource group for Azure DNS optional.

Once accepted, this will require an update of the designs of the console to remove the required field on the Azure DNS section @donnalux @CristhianF7

Related Issue(s)

Fixes #2338

How to test

  1. Ensure that the CLI and API branches are loaded (see Make Azure DNS resource group is an optional parameter #2330 for branches)
  2. Add a replace in the CLI's go.mod
    replace (
      github.com/konstructio/kubefirst-api => ../kubefirst-api
    )
  3. Run the normal command without the --dns-azure-resource-group flag:

GitHub - Azure DNS

go run . beta azure create \
  --alerts-email <email> \
  --github-org <org> \
  --domain-name <domain> \
  --gitops-template-branch sje/azure-optional-dns

GitLab - Azure DNS

go run . beta azure create \
  --alerts-email <email> \
  --domain-name <domain> \
  --git-provider gitlab \
  --gitlab-group <group> \
  --gitops-template-branch sje/azure-optional-dns

GitHub - Cloudflare DNS

go run . beta azure create \
  --alerts-email <email> \
  --github-org <org> \
  --domain-name <domain> \
  --gitops-template-branch sje/azure-optional-dns \
  --dns-provider cloudflare \
  --subdomain <subdomain>

GitLab - Cloudflare DNS

go run . beta azure create \
  --alerts-email <email> \
  --domain-name <domain> \
  --git-provider gitlab \
  --gitlab-group <group> \
  --gitops-template-branch sje/azure-optional-dns \
  --dns-provider cloudflare \
  --subdomain <subdomain>

@mrsimonemms mrsimonemms merged commit de2cba5 into main Dec 2, 2024
8 checks passed
@mrsimonemms mrsimonemms deleted the sje/azure-optional-dns-group branch December 2, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CLI so that Azure DNS resource group is an optional parameter
2 participants