Merge pull request #39 from nachandr/no_insight_generation

[RFR] Insight should not be generated with a rule with non-zero effort

data/yaml/custom_rule_insights.yaml

@@ -23,3 +23,13 @@
   when:
     builtin.file:
       pattern: "^.*\\.properties$"
+- ruleID: discover-properties-file-TC3
+  description: "Properties file (Insights TC3)"
+  labels:
+  - konveyor.io/target=discovery
+  tag: ["Properties File (Insights TC3)"]
+  message: Found properties file, Insight muts not be created
+  effort: 1
+  when:
+    builtin.file:
+      pattern: "^.*\\.properties$"

tests/test_insights.py

@@ -22,9 +22,9 @@ def test_insights_binary_app(analysis_data):
     assert 'generating static report' in output
     assert_insights_from_report_file()
 
-# Polarion TC 3503, 3504, 3505, 3506
+# Polarion TC 576, 577, 578, 589, 606
 @pytest.mark.parametrize('analysis_mode', ["source-only", "full"])
-def test_custom_rules(analysis_data, analysis_mode):
+def test_insights_custom_rules_bug_mta_3352(analysis_data, analysis_mode):
     application_data = analysis_data['tackle-testapp-project']
     custom_rule_path = os.path.join(os.getenv(constants.PROJECT_PATH), 'data/yaml',
         'custom_rule_insights.yaml')
@@ -58,3 +58,6 @@ def test_custom_rules(analysis_data, analysis_mode):
                     'Properties file (Insights TC1)', 'Properties file (Insights TC2)'):
                     # Assert insight occurrence is > 0 for each insight
                     assert len(insight['incidents']) > 0, "No insights were generated"
+                else:
+                    assert insight['description'] != 'Properties file (Insights TC3)', \
+                        "Insight incorrectly generated"