🐛 Don't use full file paths for issues #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
changed the title
Signed-off-by: Emily McMullan <[email protected]>
fabianvf
reviewed
Oct 25, 2023
| kind: Class | ||
| name: Singleton | ||
| - uri: file:///analyzer-lsp/examples/java/src/main/java/com/example/apps/Singleton.java | ||
| message: condition entries should evaluate out of order | ||
| codeSnip: " 1 package com.example.apps;\n 2 \n 3 import javax.ejb.SessionBean;\n 4 import javax.ejb.Singleton;\n 5 \n 6 @Singleton\n 7 public class Bean implements SessionBean {\n 8 }\n" | ||
| lineNumber: 7 | ||
| variables: | ||
| file: file:///analyzer-lsp/examples/java/src/main/java/com/example/apps/Singleton.java | ||
| file: /src/main/java/com/example/apps/Singleton.java |
There was a problem hiding this comment.
It looks like we're trimming off the file:// prefix, which we shouldn't be
| @@ -195,7 +199,7 @@ func main() { | |||
| } | |||
| } | |||
|
|
|||
| rulesets := eng.RunRules(ctx, ruleSets, selectors...) | |||
| rulesets := eng.RunRules(ctx, ruleSets, locations, selectors...) | |||
There was a problem hiding this comment.
Should we make this a variable on the Engine, something like location prefixes?
| for i := range locations { | ||
| tempFile := uri.File(locations[i]) | ||
| if strings.Contains(string(m.FileURI), locations[i]) { | ||
| updatedFile = strings.TrimPrefix(string(m.FileURI), string(tempFile)) |
There was a problem hiding this comment.
we should break out of the for loop here
There was a problem hiding this comment.
we can also add the file:// back here, and fix that issue
| updatedFile = strings.TrimPrefix(string(m.FileURI), string(tempFile)) | ||
| } | ||
| } | ||
| for k := range m.Variables { |
There was a problem hiding this comment.
can you just do and then not loop through stuff?
if _, ok := m.Vairables["file"]; ok {
m.Variables["file"] = updatedFile
}
Merged
aufi
pushed a commit
that referenced
this pull request
Apr 3, 2024
This slipped through somehow after merging #351 I should have re-run CI before merging #557 Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
added a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
This slipped through somehow after merging konveyor#351 I should have re-run CI before merging konveyor#557 Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
added a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
This slipped through somehow after merging konveyor#351 I should have re-run CI before merging konveyor#557 Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
added a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
This slipped through somehow after merging konveyor#351 I should have re-run CI before merging konveyor#557 Signed-off-by: Pranav Gaikwad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Full file paths for dependencies are irrelevant for the user #322