✨ add dependency location resolver and get code locations for XML, JSON files #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shawn-hurley @fabianvf @djzager Let me know what you guys think of this approach |
pranavgaikwad
force-pushed
the
main
branch
2 times, most recently
from
429f946 to
c41efdb
Compare
shawn-hurley
approved these changes
Nov 9, 2023
pranavgaikwad
force-pushed
the
main
branch
4 times, most recently
from
0be9c98 to
bcb3843
Compare
pranavgaikwad
changed the title
shawn-hurley
approved these changes
Nov 13, 2023
| @@ -128,6 +128,8 @@ func (p *builtinProvider) Init(ctx context.Context, log logr.Logger, config prov | |||
| config: config, | |||
| tags: p.tags, | |||
| UnimplementedDependenciesComponent: provider.UnimplementedDependenciesComponent{}, | |||
| locationCache: make(map[string]float64), | |||
There was a problem hiding this comment.
Why float and not int?
There was a problem hiding this comment.
For some reason, in provider API, the value is float
fabianvf
approved these changes
Nov 13, 2023
|
Looks good! |
pranavgaikwad
force-pushed
the
main
branch
2 times, most recently
from
2400be0 to
667ff88
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
pranavgaikwad
force-pushed
the
main
branch
2 times, most recently
from
02b98ae to
4f3b1f2
Compare
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #410
Fixes #254
There were two choices to do this:
I chose No. 2 because output API change not needed. But I am not fan of it as its complicated & perf penalty. Asking for your inputs on the approach. If we do go with 2, I think we should we should still remove it in later versions in favor of a new optional field on Dep. Even if we did add it now, it would be non-intrusive.