✨ Windows Compatibility-Add PowerShell Script as an Alternative to Grep on Linux #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kthatipally
changed the title
kthatipally
changed the title
:sparkles:) [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux
kthatipally
changed the title
:sparkles:) [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux:sparkles: [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux
kthatipally
changed the title
:sparkles: [Windows Compatibility] Add PowerShell Script as an Alternative to Grep on Linux
kthatipally
changed the title
shawn-hurley
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
This looks good assuming the power shell code works.
Another option if you were interested in doing, is to create a new "grep_windows.go" and "grep_nix.go" that will compile grep_nix using build tags when on a nix system and windows when on windows.
This is a decent resource to see what I mean: https://dave.cheney.net/2013/10/12/how-to-use-conditional-compilation-with-the-go-build-tool
I think that we can do this as a follow up though if we want
1 task
kthatipally
force-pushed
the
add-powershell-alternative-to-grep
branch
from
e471059 to
5b7b589
Compare
kthatipally
changed the title
eemcmullan
added
the
cherry-pick/release-0.6
…ript as an alternative to grep Signed-off-by: kthatipally <[email protected]>
Signed-off-by: kthatipally <[email protected]>
kthatipally
force-pushed
the
add-powershell-alternative-to-grep
branch
from
5b7b589 to
c9dab07
Compare
eemcmullan
pushed a commit
to eemcmullan/analyzer-lsp
that referenced
this pull request
Nov 26, 2024
…ep on Linux (konveyor#690) PR Summary This pull request introduces a PowerShell-based alternative to the grep command, ensuring that the built-in File Searching feature is also compatible with Windows systems. service_client.go: Added runOSSpecificGrepCommand to handle grep functionality for both Windows (using PowerShell) and Unix-based systems. This function checks for the OS platform and invokes powershell(windows) and grep(linux). Replaced direct grep command execution with runOSSpecificGrepCommand to support cross-platform compatibility. service_client.go: Implemented parseGrepOutputForFileContent to parse the output from both PowerShell and grep. This enhancement not only refines the existing parsing mechanism for Linux but also accommodates Windows file path patterns and addresses issues with the split function when multiple ':' appear in the input. WIP: Testing --------- Signed-off-by: kthatipally <[email protected]>
eemcmullan
pushed a commit
to eemcmullan/analyzer-lsp
that referenced
this pull request
Nov 26, 2024
…ep on Linux (konveyor#690) PR Summary This pull request introduces a PowerShell-based alternative to the grep command, ensuring that the built-in File Searching feature is also compatible with Windows systems. service_client.go: Added runOSSpecificGrepCommand to handle grep functionality for both Windows (using PowerShell) and Unix-based systems. This function checks for the OS platform and invokes powershell(windows) and grep(linux). Replaced direct grep command execution with runOSSpecificGrepCommand to support cross-platform compatibility. service_client.go: Implemented parseGrepOutputForFileContent to parse the output from both PowerShell and grep. This enhancement not only refines the existing parsing mechanism for Linux but also accommodates Windows file path patterns and addresses issues with the split function when multiple ':' appear in the input. WIP: Testing --------- Signed-off-by: kthatipally <[email protected]> Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
pushed a commit
to eemcmullan/analyzer-lsp
that referenced
this pull request
Nov 26, 2024
…ep on Linux (konveyor#690) PR Summary This pull request introduces a PowerShell-based alternative to the grep command, ensuring that the built-in File Searching feature is also compatible with Windows systems. service_client.go: Added runOSSpecificGrepCommand to handle grep functionality for both Windows (using PowerShell) and Unix-based systems. This function checks for the OS platform and invokes powershell(windows) and grep(linux). Replaced direct grep command execution with runOSSpecificGrepCommand to support cross-platform compatibility. service_client.go: Implemented parseGrepOutputForFileContent to parse the output from both PowerShell and grep. This enhancement not only refines the existing parsing mechanism for Linux but also accommodates Windows file path patterns and addresses issues with the split function when multiple ':' appear in the input. WIP: Testing --------- Signed-off-by: kthatipally <[email protected]> Signed-off-by: Emily McMullan <[email protected]>
eemcmullan
added a commit
that referenced
this pull request
Nov 26, 2024
…t… (#739) Signed-off-by: kthatipally <[email protected]> Signed-off-by: Emily McMullan <[email protected]> Co-authored-by: Keerthi Thatipally <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request introduces a PowerShell-based alternative to the grep command, ensuring that the built-in File Searching feature is also compatible with Windows systems.
service_client.go: Added runOSSpecificGrepCommand to handle grep functionality for both Windows (using PowerShell) and Unix-based systems. This function checks for the OS platform and invokes powershell(windows) and grep(linux). Replaced direct grep command execution with runOSSpecificGrepCommand to support cross-platform compatibility.
service_client.go: Implemented parseGrepOutputForFileContent to parse the output from both PowerShell and grep. This enhancement not only refines the existing parsing mechanism for Linux but also accommodates Windows file path patterns and addresses issues with the split function when multiple ':' appear in the input.
WIP: Testing