Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Print Maven output on error #697

Closed
wants to merge 8 commits into from

Conversation

jmle
Copy link
Contributor

@jmle jmle commented Sep 4, 2024

Fixes #696

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle force-pushed the print-mvn-output-on-error branch from 859d919 to 7373e78 Compare September 4, 2024 18:58
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, helpful for debugging!

LGTM

@jmle jmle added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Sep 25, 2024
eemcmullan and others added 6 commits October 25, 2024 10:41
With the current external provider module names, we cannot import these
providers into other projects, such as kantra. Updating the module names
to the path inside of the main repo should fix this issue.

Signed-off-by: Emily McMullan <[email protected]>
Without running analysis in a container, logs such as below were sent to
stdout and cluttering other analysis logs:

```
INFO[0006] evaluating rules for violations. see analysis.log for more info
2024/10/03 11:19:01 Re-opening moved/deleted file .metadata/.log ...
2024/10/03 11:19:01 Waiting for .metadata/.log to appear...
2024/10/03 11:19:01 Successfully reopened .metadata/.log
```

Logs from the language server are still available:

```
time="2024-10-14T15:34:38-04:00" level=info msg="language server log" line="!MESSAGE KONVEYOR_LOG: source-only analysis mode only scoping to Sources" provider=java
time="2024-10-14T15:34:38-04:00" level=info msg="language server log" line="!MESSAGE KONVEYOR_LOG: found errors: [] warnings: []" provider=java
time="2024-10-14T15:34:38-04:00" level=info msg="language server log" line="!MESSAGE KONVEYOR_LOG: pattern: TypeDeclarationPattern: qualification<javax.management>, type<j2ee*> TypeDeclarationPattern: pkg<*>, enclosing<*>, type<j2ee*>, pattern match, case sensitive, generic full match, fine grain: none | TypeReferencePattern: qualification<javax.management>, type<j2ee*>, pattern match, case sensitive, generic full match, fine grain: none" provider=java
```

Signed-off-by: Emily McMullan <[email protected]>
@jmle jmle closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REF] Java provider log maven command output.
5 participants