Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ CP #690 - Windows Compatibility-Add PowerShell Script as an Alternat… #739

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

eemcmullan
Copy link
Contributor

No description provided.

…ep on Linux (konveyor#690)

PR Summary
This pull request introduces a PowerShell-based alternative to the grep
command, ensuring that the built-in File Searching feature is also
compatible with Windows systems.

service_client.go: Added runOSSpecificGrepCommand to handle grep
functionality for both Windows (using PowerShell) and Unix-based
systems. This function checks for the OS platform and invokes
powershell(windows) and grep(linux). Replaced direct grep command
execution with runOSSpecificGrepCommand to support cross-platform
compatibility.

service_client.go: Implemented parseGrepOutputForFileContent to parse
the output from both PowerShell and grep. This enhancement not only
refines the existing parsing mechanism for Linux but also accommodates
Windows file path patterns and addresses issues with the split function
when multiple ':' appear in the input.

WIP: Testing

---------

Signed-off-by: kthatipally <[email protected]>
Signed-off-by: Emily McMullan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants