Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ CP #717 - Allow configurable path for fernflower #742

Merged
merged 1 commit into from
Dec 3, 2024
Merged

✨ CP #717 - Allow configurable path for fernflower #742

merged 1 commit into from
Dec 3, 2024

Conversation

eemcmullan
Copy link
Contributor

No description provided.

shawn-hurley
shawn-hurley approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong,

The way we constantly have to change the arguments to the helper functions for things like this, starts to make me think that they should be a struct and that we should refactor but out of scope of this change.

@eemcmullan eemcmullan changed the title ✨ : CP #717 - Allow configurable path for fernflower ✨ CP #717 - Allow configurable path for fernflower Dec 3, 2024
@eemcmullan eemcmullan merged commit 6ec6ba8 into konveyor:release-0.6 Dec 3, 2024
9 of 10 checks passed
This was referenced Dec 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

@shawn-hurley shawn-hurley shawn-hurley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eemcmullan @shawn-hurley @dymurray