Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Remove slash from java bundle for windows #745

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

eemcmullan
Copy link
Contributor

@eemcmullan eemcmullan added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2024
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to remove the starting slash

@eemcmullan eemcmullan added cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 11, 2024
@eemcmullan eemcmullan merged commit 1480e15 into konveyor:main Dec 11, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
eemcmullan added a commit that referenced this pull request Dec 12, 2024
relies on konveyor/java-analyzer-bundle#115

Signed-off-by: Emily McMullan <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Emily McMullan <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Emily McMullan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants