🐛 Adding ability for provider and service client to shutdown gracefully #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by catching signals and closing the pipes Signed-off-by: Shawn Hurley <[email protected]>
|
@eemcmullan Can you test this PR w/ containerless kantra when you have a chance. |
shawn-hurley
changed the title
pranavgaikwad
approved these changes
Dec 10, 2024
eemcmullan
pushed a commit
to eemcmullan/analyzer-lsp
that referenced
this pull request
Dec 11, 2024
…ly (konveyor#746) This will update and catch the context cancel to close the pipes for stdin and stdout. Signed-off-by: Shawn Hurley <[email protected]>
eemcmullan
added a commit
that referenced
this pull request
Dec 11, 2024
…wn grac… (#748) …efully (#746) This will update and catch the context cancel to close the pipes for stdin and stdout. Signed-off-by: Shawn Hurley <[email protected]> Co-authored-by: Shawn Hurley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will update and catch the context cancel to close the pipes for stdin and stdout.