🐛 Improve accuracy of METHOD_CALL and CONSTRUCTOR_CALL matches #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
force-pushed
the
main
branch
3 times, most recently
from
86285f4 to
9f0fe8c
Compare
|
This should fail because this gets rid of false positives in our test app. |
|
Tests fixed here konveyor/go-konveyor-tests#155 |
pranavgaikwad
force-pushed
the
main
branch
4 times, most recently
from
319d25c to
625b5c6
Compare
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
Signed-off-by: Pranav Gaikwad <[email protected]>
…ng LS Signed-off-by: Shawn Hurley <[email protected]>
Adding query replace to make java regex in qualification match
Signed-off-by: Pranav Gaikwad <[email protected]>
shawn-hurley
approved these changes
Jul 9, 2024
This was referenced Jul 10, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Tests PR: 155
This specifically addresses cases with queries containing FQN searches and/or *. We get more symbols than needed from jdt in these cases, we add logic to filter-out matches by inspecting full names of symbols.