🐛 remove static map, so that each symbol provider for a search is new #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
commented
Jul 15, 2024
| @@ -162,7 +162,7 @@ public boolean visit(ClassInstanceCreation node) { | |||
| // get fqn of the method being called | |||
| ITypeBinding declaringClass = binding.getDeclaringClass(); | |||
| if (declaringClass != null) { | |||
| String fullyQualifiedName = declaringClass.getQualifiedName() + "." + binding.getName(); | |||
| String fullyQualifiedName = declaringClass.getQualifiedName(); | |||
There was a problem hiding this comment.
During testing for this, I noticed that the Qualified Name from Class was the full name (java.io.File) and adding the binding made it (java.io.File.File) it still mateched the queries but this is more correct
dymurray
changed the title
dymurray
reviewed
Jul 15, 2024
...yzer-bundle.core/src/main/java/io/konveyor/tackle/core/internal/symbol/CustomASTVisitor.java
Outdated
Show resolved
Hide resolved
jmle
approved these changes
Jul 15, 2024
shawn-hurley
force-pushed
the
bugfix/remove-static-map
branch
from
5763789 to
b32443e
Compare
|
When running local with this change, getting rules erroring in the hub but not locally. |
Signed-off-by: Shawn Hurley <[email protected]>
Signed-off-by: Shawn Hurley <[email protected]>
shawn-hurley
force-pushed
the
bugfix/remove-static-map
branch
from
6ad9ae9 to
316d71b
Compare
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.