🐛 Adding settings to the init script for jdtls #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Hurley <[email protected]>
|
Looks good |
jmle
approved these changes
Jul 23, 2024
jmontleon
pushed a commit
to konveyor/operator
that referenced
this pull request
Jul 23, 2024
#366) related to konveyor/java-analyzer-bundle#106 Signed-off-by: Shawn Hurley <[email protected]>
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting max RAM to 70% and keeping the min to 1 GB that means that the minimum that you can run the pod with is 1.5 GB, but I still think we should use 2 GB memory and document that this is the minimum requirement.
Creating a documentation task to track this, and follow up PRs' to change the numbers once this merges.
For now you should see about 3GB of max space for the process to use until the limits are turned down.