Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotations when coming from java.lang (like @Override) #113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmle
Copy link
Collaborator

@jmle jmle commented Dec 5, 2024

  • Also, java.lang is a default package in Java and never imported. In order to match on the FQNs of annotations, we use the import list, but in this case that doesn't work. Added some conditions to make it a special case.

@jmle jmle changed the title 🐛 Fix build (Java21 needed now) and also fix annotations when coming from java.lang (like @Override) 🐛 Fix build (Java21 needed now) and also fix annotations when coming from java.lang (like @Override) Dec 5, 2024
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for upstream main.

@jmle jmle force-pushed the fix-build-and-java-lang-annotations branch from 4cf8170 to 24adea1 Compare December 10, 2024 16:12
@jmle jmle changed the title 🐛 Fix build (Java21 needed now) and also fix annotations when coming from java.lang (like @Override) Fix annotations when coming from java.lang (like @Override) Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants