👻 Improve running as non-root #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontleon
force-pushed
the
improve-non-root
branch
3 times, most recently
from
77b00c0 to
1ec87df
Compare
Signed-off-by: Jason Montleon <[email protected]>
jmontleon
force-pushed
the
improve-non-root
branch
from
1ec87df to
09d4170
Compare
shawn-hurley
approved these changes
Jan 23, 2024
|
I think the soft link works, and then I think that we do need to the updates of binaries. We will have to make the changes in multiple PRs over the repos; I think that we can create a high-priority fix and get the basics working. |
aufi
approved these changes
Jan 24, 2024
|
Merging and on build will merge the analyzer-pr |
shawn-hurley
added
the
cherry-pick/release-0.3
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
Signed-off-by: Jason Montleon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can at least run as non-root.
I would also proprose moving binaries that need to be accessible to all users be installed in /usr/local/bin. But as of right now it seems we have configs hard coded to this location.
https://github.com/konveyor/java-analyzer-bundle/blob/main/Dockerfile#L41
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s09.html
https://github.com/konveyor/analyzer-lsp/blob/f6cdf400bf2c7e236b050f31300e9e504e241d78/provider_settings.json.sample#L8
We could probably keep the handling to /root/.m2 similar, except update the permissions changes to only adjust /root/.m2. Alternatively, set HOME=/ and set it up and adjust permissions there instead of linking it.