Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add ability to set search scope by file paths #94

Merged
merged 2 commits into from
May 20, 2024

Conversation

pranavgaikwad
Copy link
Contributor

@pranavgaikwad pranavgaikwad commented May 10, 2024

This adds ability to create a search scope from file paths, and also disables test files from scope (this is the first true argument to createSearchScope function). Note that the search scope can only be set at a package level. Haven't yet figured out how to get it down to compilation units. But I think this is enough for now.

Copy link
Collaborator

@jmle jmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do eventually need to e2e testing in the repo, to make sure this works, but I think for now this LGTM

Signed-off-by: Pranav Gaikwad <[email protected]>
@pranavgaikwad
Copy link
Contributor Author

@shawn-hurley @jmle hey folks, I am going to test this PR with analyzer-lsp, I added test cases there. If that PR passes, we should be good with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants